Search Linux Wireless

Re: [PATCH v2] This allows ath5k to support virtual STA and AP interfaces.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2010-09-24 8:17 PM, Ben Greear wrote:
> On 09/24/2010 10:46 AM, Nick Kossifidis wrote:
>> 2010/9/23<greearb@xxxxxxxxxxxxxxx>:
>>> From: Ben Greear<greearb@xxxxxxxxxxxxxxx>
>>>
>>> +#define ATH5K_VIF_MAX  2048
>>
>> This is too much !!! 2048 interfaces with a total of 4 beacon buffers
>> 40 rx buffers and 200 tx buffers ? Has anyone tested this ?
>>
>> Also think about embedded devices, we don't want to waste memory like this...
>>
>>> +       struct ieee80211_vif *vifs[ATH5K_VIF_MAX];
> 
> It only costs 4 or 8 bytes per pointer as long as no one actually
> adds the vifs.
> 
> We've tested at least 128 on an old 1Ghz VIA system, and I'd hope for more
> on more modern hardware.  I didn't think the driver should make the decision
> to limit un-necessarily.
> 
> If you still think this is too much, then tell me the biggest number
> you wouldn't complain about :)
Actually, looking at the code, I don't see much reason to even have this
array. Most of the time the code is iterating over the list anyway, so
we might as well just have a linked list here...
That way we can avoid introducing bogus limitations or memory waste.

- Felix
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux