On 09/23/2010 07:06 AM, Johannes Berg wrote:
On Thu, 2010-09-23 at 06:57 -0700, Ben Greear wrote:
On 09/20/2010 11:47 PM, Johannes Berg wrote:
On Mon, 2010-09-20 at 14:39 -0700, greearb@xxxxxxxxxxxxxxx wrote:
From: Ben Greear<greearb@xxxxxxxxxxxxxxx>
When using multiple STA interfaces on the same radio, some
data packets need to be received on all interfaces
(broadcast, for instance).
Make the STA loop look similar to the mgt-data loop.
Also, add logic to check RX_FLAG_MMIC_ERROR for last
interface in mgt-data loop.
This needs review.
Looks fine to me, I think.
Does this need any more work before being accepted upstream?
Well, I personally would've tried to reduce the code duplication between
the two loops, but right now I'm not sure I see how to.
I could move some of the rx setup code into prepare_for_handlers,
but not sure how much that would help readability.
In my opinion, that would be a good candidate for a followup
patch instead of adding that to this patch, though.
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
