On Tue, Sep 21, 2010 at 12:31 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Tue, 2010-09-21 at 15:27 -0400, Luis R. Rodriguez wrote: > >> + Â Â mutex_lock(&local->sta_mtx); >> + Â Â list_for_each_entry(sta, &local->sta_list, list) >> + Â Â Â Â Â Â if (local->hw.flags & IEEE80211_HW_AMPDU_AGGREGATION) >> + Â Â Â Â Â Â Â Â Â Â set_sta_flags(sta, WLAN_STA_BLOCK_BA); >> + Â Â mutex_unlock(&local->sta_mtx); >> + > > This is really expensive, I don't think we should do it this way. > Wouldn't it be possible to put a check into place wherever the flag is > checked too? Good point, sure, we'll need more checks and conditions added later too so that would also help to avoid running into this code for non-11n cards. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
