On Tue, Sep 21, 2010 at 03:55:01PM +0530, Felix Fietkau wrote: > On 2010-09-21 12:17 PM, Vasanthakumar Thiagarajan wrote: > > On Tue, Sep 21, 2010 at 03:36:28PM +0530, Felix Fietkau wrote: > >> That seems like code duplication to me. The caldata already has the > >> channel number and the channel flags. ath9k_hw_reset() clears the entire > >> caldata whenever that changes. Because of that, ah->caldata->paprd_done > >> should have already been set to zero automatically after the reset > >> triggered by an operating channel change. > >> Is that part not working, or why did you write this patch? > >> Either way, we should not have a separate check just for paprd, it > >> belongs to the other calibrations. > > > > I don't want to do paprd again whenever coming back from off-channel > > (like during background scanning). > That's not what it does. The caldata is only reset after *operating* > channel changes, not just after off-channel activity. > The reason this works is that for off-channel activity, the caldata > pointer is not passed to the hw reset function, so it can't reset any > data there. The intention behind that is that offchannel activity should > never trigger any long calibration activity, nor change the state of the > existing long calibration data. yeah I see that. probably I completely ignored this SC_OP_OFFCHANNNEL for sometime, thanks. Vasanth -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
