2010/9/19 Levi, Shahar <shahar_levi@xxxxxx>: > I am confuse. If there option that patch isn't applied from a series how we could trust any patches series we send to that list. I would greatly appreciate if you help me to understand and elaborate what it bisection danger. Am I missing something? > I really appreciate your willingness to help. Unless people dislike your patches, there's no danger that they won't all be applied to the kernel. That said, there are still circumstances when only part of a patch series like your one will be applied to a kernel. One of these is when a user is using git bisection to find exactly which commit caused a particular bug. So, let's say you upgrade your kernel from 2.6.35 to 2.6.38 and your wl1271 device now won't connect to an AP running on some random proprietary hardware. The simplest way to determine exactly which patch caused this issue is to use git bisect to do a binary search over the changes between these two kernel versions to determine the exact patch that broke it. Now, let's assume that, this particular piece of hardware won't connect to *anything* when 802.11n support is added, so you've already excluded that from your kernel. If git bisect decides to leap into the middle of your series, so that 802.11n support is added before the Kconfig option is added, then 802.11n support will be unconditionally enabled, and you'll see the symptoms of that bug, and won't be able to quickly determine whether the bug existed before the 802.11n patches or after, and git bisect might wrongly assume that these patches were the cause of the bug. As such, it's generally regarded as a good idea to introduce Kconfig options with the code they guard. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
