On Thu, Sep 16, 2010 at 11:30 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Thu, 2010-09-16 at 11:22 -0700, Luis R. Rodriguez wrote: >> On Thu, Sep 16, 2010 at 5:58 AM, Johannes Berg >> <johannes@xxxxxxxxxxxxxxxx> wrote: >> > From: Johannes Berg <johannes.berg@xxxxxxxxx> >> > >> > When a driver advertises p2p device support, >> > mac80211 will handle it, but internally it will >> > rewrite the interface type to STA/AP rather than >> > P2P-STA/GO since otherwise a lot of paths need >> > to be touched that are otherwise identical. A >> > p2p boolean tells drivers whether or not a given >> > interface will be used for p2p or not. >> > >> > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx> >> >> While at it can you add a is_beaconing_iftype() or something, that >> should reduce code and make it easier to check for these modes. > > Err, it doesn't really change for drivers, since it's still AP/IBSS -- > since GO is just an AP subtype internally. Well if the iftype is a beaconing one it used to use AP interface type before and now its a GO then yeah I could see this requiring changes in drivers. Apart from the filter stuff ath9k does have some checks for current operating interface type IIRC. > And anyway, I wouldn't use it > internally, so does it really belong into this patch? If there is not much usage for it in mac80211 / cfg80211 sure, I just thought there would be a lot of uses for it in mac80211 / cfg80211 but I guess there isn't. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html