Search Linux Wireless

Re: [RFC] mac80211: avoid recalc_idle in monitor mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2010-09-15 at 18:35 +0530, Rajkumar Manoharan wrote:

> > > -	mutex_lock(&local->mtx);
> > > -	hw_reconf_flags |= __ieee80211_recalc_idle(local);
> > > -	mutex_unlock(&local->mtx);
> > > +	if (sdata->vif.type != NL80211_IFTYPE_MONITOR) {
> > > +		mutex_lock(&local->mtx);
> > > +		hw_reconf_flags |= __ieee80211_recalc_idle(local);
> > > +		mutex_unlock(&local->mtx);
> > > +	}
> > 
> > Hmm, that doesn't seem right, wouldn't it be idle to start with?

> not sure whether I am missing something here. Shouldn't we be receiving frames
> in monitor mode as soon as the interface is up and running. I don't see any
> reason why should we even care about IDLE state for MONITOR mode.

But if the device is already idle, adding the monitor wouldn't change it
either, which seems wrong, no?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux