On Wed, Sep 15, 2010 at 11:06:21AM +1000, Jonathan Guerin wrote: > > also i think current ath5k_hw_reset_tx_queue() is buggy and sets the AIFS > > wrongly. it uses ah->ah_aifs + tq->tqi_aifs which is 2 + AR5K_TXQ_USEDEFAULT > > which results in 2 + (-1). that does not make sense to me and i will post a > > patch fixing up some of that confusion (but not the SIFS issue) today. > > SIFS is coming up short: > ox230/0x28 = 14us Just a wild guess, driver may include a small fudge factor to account for time spent in qcu. At one point I compared all of the initvals to those from the HAL; we're at least bug-compatible with it if there are errors here. > By the way, I may be completely wrong about some of these things, I'm > just going off the understanding I have regarding the register values. Well mostly no one has looked at them, so you may well have found some problems. FWIW if you use coverage classes (not default), we appear to use the right values there. -- Bob Copeland %% www.bobcopeland.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
