Search Linux Wireless

Re: [PATCH 1/2] ath9k: fix BSSID mask calculation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2010-09-14 7:59 PM, Ben Greear wrote:
> It seems I saw this code over-write the mask with a bad value
> when debugging this a few days ago..but perhaps I was mistaken,
> or perhaps your patch fixes this already.
> 
> 	/* configure bssid mask */
> 	if (ah->caps.hw_caps & ATH9K_HW_CAP_BSSIDMASK)
> 		ath_hw_setbssidmask(common);
> 
> My plan was to have it call ath9k_set_bssid_mask(common->hw) instead.
Not necessary. The bssid mask only needs to be recalculated when
interfaces are brought up (and maybe when they are brought down, but
that's less important).
The code here only needs to apply the precalculated mask to the hardware.

> Were you able to create multiple STA interfaces and have them
> send/receive data with your patch?
I did not test that, but I suspect that my changes help there as well.

- Felix
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux