Search Linux Wireless

Re: mesh beacons broken on HEAD for libertas_tf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2010-09-10 at 18:23 -0700, Steve deRosier wrote:

> 1. Move the setting of SDATA_STATE_RUNNING to earlier in the function.
>  This is obviously problematic, having to unset it on errors or so on.

Yeah, that's why I did it this way mostly.

> 3. Put an exception to the check in ieee80211_bss_info_change_notify()
> so that if vif->type is mesh, that we don't check the
> SDATA_STATE_RUNNING bit.  Fairly straight forward and I know how to do
> that.

I see you posted a patch for this. I don't think it's a great change,
and I think you may also need to check netif_running() which is true
earlier in the function, but not while the interface is really down.

> 4. Somehow delay the mesh setup from setting up beacons till after the
> ieee80211_do_open() call finishes.  I'm not sure how to accomplish
> this in a sensible way.

That would be best, really. The main issue is that the way mesh is
configured is really sad -- you set parameters before bringing up the
interface and then they take effect. It'd be _much_ nicer if it behaved
like IBSS in cfg80211, so that you can set parameters to "join" a mesh
and then you could "leave" a mesh again without setting the interface
down, etc. Some backward compat code might be needed in cfg80211 so if
you set an interface up while it's already configured, these things take
effect already ...

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux