Dear Luis, we are moving your patch to the latest version whenever we have the time to do so... You had sent us two patch files: http://www.mk.kernel.org/pub/linux/kernel/people/mcgrof/patches/wow-07-21.pa tch http://www.mk.kernel.org/pub/linux/kernel/people/mcgrof/patches/iw-add-wow.p atch The first one is successfully accomplished, but we have problems with the second one. I am giving a summary of the errors that we get below. There are files and variables defined in that patch that we cannot find anywhere and do not know what they should do. Can you please provide us with some hints regarding those errors? best regards Burak ?NL_CB_CUSTOM? undeclared (first use in this function) wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 159 C/C++ Problem ?NL_CB_VALID? undeclared (first use in this function) wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 159 C/C++ Problem ?NL_OK? undeclared (first use in this function) wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 137 C/C++ Problem ?NL_SKIP? undeclared (first use in this function) wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 129 C/C++ Problem ?stderr? undeclared (first use in this function) wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 79 C/C++ Problem errno.h: No such file or directory wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 21 C/C++ Problem expected ?)? before ?(? token wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 162 C/C++ Problem expected ?)? before string constant wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 95 C/C++ Problem implicit declaration of function ?fprintf? wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 79 C/C++ Problem implicit declaration of function ?genlmsg_attrdata? wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 123 C/C++ Problem implicit declaration of function ?genlmsg_attrlen? wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 124 C/C++ Problem implicit declaration of function ?nl_cb_set? wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 159 C/C++ Problem implicit declaration of function ?nla_get_u32? wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 132 C/C++ Problem implicit declaration of function ?nla_parse? wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 123 C/C++ Problem implicit declaration of function ?NLA_PUT_U32? wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 89 C/C++ Problem implicit declaration of function ?nlmsg_data? wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 119 C/C++ Problem implicit declaration of function ?printf? wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 128 C/C++ Problem iw.h: No such file or directory wow.c /wireless-testing/drivers/net/wireless/ath/ath9k line 32 C/C++ Problem -----Ursprüngliche Nachricht----- Von: Luis R. Rodriguez [mailto:lrodriguez@xxxxxxxxxxx] Gesendet: Dienstag, 27. Juli 2010 19:20 An: Simsek, Burak Cc: Luis Rodriguez; linux-wireless@xxxxxxxxxxxxxxx Betreff: Re: [ath9k-devel] [PATCH 4/5] mac80211: add WoW support On Tue, Jul 27, 2010 at 08:12:10AM -0700, Simsek, Burak wrote: > Dear Luis, > > I have found out that you have worked on WoW for ath9k for a while. > However, in the wiki page of wireless.kernel.org the current state is > written as ongoing work. Can you please tell me whether you were > successful while implementing WoW. Is there anything that we could use? WoW worked for me but inconsistantly and at the time of writing the patches I had to do quite a lot of coordination with Johannes since he had a lot of API changes and his changes needed to get merged first. I also found quite a few issues in mac80211 back then but I believe we have resolved all of them by now so I would expect that if the same WoW-only patches to be rebased and tested we may get better results. I stopped working on the WoW stuff due to lack of time to keep testing them but the last series can be edited to remove all of the already merged stuff and test out the new stuff. The more challenging thing for me was to actually get a WoW enabled 802.11 card, these are not as popular as you would hope. The EEPROM would be modified when WoW is enabled but WoW requires some actual hardware mucking to allow for the PCI Wake signal which is typically blocked off. If the EEPROM has WoW enabled then the hardware mucking would have been done. To test WoW you also need to drop Network Manager and use the supplicant directly so that during suspend you remain associated. I should note that WoW will only work on non-WPA networks with ath9k due to the lack of hardware CPU, during suspend there is only power for the 802.11 hardware, the CPU on your box would be asleep but would be required for group key changes. The way I was thinking of doing this was to only enable WoW through cfg80211 for ath9k if and only if you are associated and you are connected to a non WPA network. WoW would work with encryption on our USB devices where there is a CPU though. You can find my last series here: http://www.mk.kernel.org/pub/linux/kernel/people/mcgrof/patches/wow-07-21.pa tch http://www.mk.kernel.org/pub/linux/kernel/people/mcgrof/patches/iw-add-wow.p atch If you manage to do what I noted above, get an actual WoW enabled card, and it works reliably I'd gladly welcome and ACK the patches :) Luis
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
