On Sun, Sep 12, 2010 at 9:17 PM, Bruno Randolf <br1@xxxxxxxxxxx> wrote: > On Sun September 12 2010 02:27:52 you wrote: >> On Wed, Sep 08, 2010 at 04:04:59PM +0900, Bruno Randolf wrote: >> > Replace ah_aes_support and ah_combined_mic with common ath_crypt_caps >> > ATH_CRYPT_CAP_CIPHER_AESCCM and ATH_CRYPT_CAP_MIC_COMBINED. >> > >> > Signed-off-by: Bruno Randolf <br1@xxxxxxxxxxx> >> > >> > --- a/drivers/net/wireless/ath/ath5k/base.c >> > +++ b/drivers/net/wireless/ath/ath5k/base.c >> > @@ -3298,7 +3298,7 @@ ath5k_set_key(struct ieee80211_hw *hw, enum >> > set_key_cmd cmd, >> > >> > case WLAN_CIPHER_SUITE_TKIP: >> > break; >> > >> > case WLAN_CIPHER_SUITE_CCMP: >> > - if (sc->ah->ah_aes_support) >> > + if (common->crypt_caps & ATH_CRYPT_CAP_CIPHER_AESCCM) >> > >> > break; >> > >> > return -EOPNOTSUPP; >> >> This could be done by the common code too, right? > > yes... ath9k doesn't do this, but i left the old code because i wasn't sure if > we need it or not. can we sort this out in a following patch? Yeah, I guess only certain ath5k chipsets do CCMP while all ath9k ones do.. for sure, follow-up patches are fine for my minor comments, none of them affect functionality. -- Bob Copeland %% www.bobcopeland.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
