On Thu, Sep 9, 2010 at 15:49, Steve deRosier <steve@xxxxxxxxxxx> wrote:
> On Wed, Sep 8, 2010 at 7:16 PM, Julian Calaby <julian.calaby@xxxxxxxxx> wrote:
>> More nits:
>>
>> On Thu, Sep 9, 2010 at 09:25, Steve deRosier <steve@xxxxxxxxxxx> wrote:
>>> This patch adds tx-feedback to libertas_tf_sdio so that mac80211 rate
>>> adaptation and other bookkeeping tasks function properly.
>>>
>>> Signed-off-by: Steve deRosier <steve@xxxxxxxxxxx>
>>> ---
>>> drivers/net/wireless/libertas_tf/deb_defs.h | 5 ++
>>> drivers/net/wireless/libertas_tf/if_sdio.c | 42 +++++++++++------
>>> drivers/net/wireless/libertas_tf/main.c | 65 ++++++++++++++++----------
>>> 3 files changed, 72 insertions(+), 40 deletions(-)
>>>
>>> diff --git a/drivers/net/wireless/libertas_tf/deb_defs.h b/drivers/net/wireless/libertas_tf/deb_defs.h
>>> index 99a7478..8e86e11 100644
>>> --- a/drivers/net/wireless/libertas_tf/deb_defs.h
>>> +++ b/drivers/net/wireless/libertas_tf/deb_defs.h
>>> @@ -1063,25 +1077,23 @@ static void if_sdio_interrupt(struct sdio_func *func)
>>> if (ret)
>>> goto out;
>>>
>>> -// lbtf_deb_sdio("interrupt: 0x%X\n", (unsigned)cause);
>>> -
>>> sdio_writeb(card->func, ~cause, IF_SDIO_H_INT_STATUS, &ret);
>>> if (ret)
>>> goto out;
>>
>> Shouldn't this have been removed instead of being commented in the
>> patch that commented it?
>>
>
> Until this time I was using this line intermittently. I frequently
> uncommented it in order to see some debugging info. But as it is in
> an interrupt, it creates a lot of noise that I usually didn't want to
> see. Once I was past a certain point (here) and didn't need it
> anymore, it got deleted.
>
> I could have rolled all the patches into one single patch that was
> nice and neat with a blue bow, but then you wouldn't have seen all the
> fun I had and you would have missed out. :)
Hehehe. Quite. I guess I'm just more pedantic about such things than
most people. Ah well =)
Thanks,
--
Julian Calaby
Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
