Search Linux Wireless

Re: [PATCH] libertas_tf_usb: fix libertas_tf_usb to match structural changes in libertas_tf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 9, 2010 at 09:28, Steve deRosier <steve@xxxxxxxxxxx> wrote:
> The development of the libertas_tf_sdio driver introduced structural
> changes in libertas_tf.  Most notably, firmware loading and starting
> was needed in the probe stage due to the requirement that mac80211
> have the MAC address set before the starting of mac80211 in add_card.
> This patch fixes libertas_tf_usb to match these structural changes
> as needed.
>
> Signed-off-by: Steve deRosier <steve@xxxxxxxxxxx>

I'm not sure if the usb part of this driver is still functional, but
even if it isn't, it may be nicer (bisectability, etc.) to re-order
your patches like so:
1. Make the structural changes (and clean ups) in the base code and usb driver
2. Introduce the sdio driver in a single patch, taking advantage of
these changes.

It will also mean that the sdio driver will be introduced to the
kernel in a working state, rather than introduced in a partially
working state, then fixed over several commits.

Thanks,

-- 

Julian Calaby

Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux