Minor nit: On Thu, Sep 9, 2010 at 09:25, Steve deRosier <steve@xxxxxxxxxxx> wrote: > This patch adds a method to do a firmware/chip reset to the sdio driver and > attempts to reload the firmware. > > Signed-off-by: Steve deRosier <steve@xxxxxxxxxxx> > --- > drivers/net/wireless/libertas_tf/if_sdio.c | 40 +++++++++++++++++++++++---- > drivers/net/wireless/libertas_tf/main.c | 7 ++++- > 2 files changed, 40 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/wireless/libertas_tf/if_sdio.c b/drivers/net/wireless/libertas_tf/if_sdio.c > index fed5aff..1e72b4c 100644 > --- a/drivers/net/wireless/libertas_tf/main.c > +++ b/drivers/net/wireless/libertas_tf/main.c > @@ -360,7 +364,8 @@ static int lbtf_op_start(struct ieee80211_hw *hw) > return 0; > > err_prog_firmware: > -// priv->hw_reset_device(card); > + if (priv->hw_reset_device) > + priv->hw_reset_device(card); Should this not be done in the first patch? - rather than just commenting out the call: Would commenting out this line in the first patch make the original version of libertas_tf unable to handle firmware errors properly? > lbtf_deb_leave_args(LBTF_DEB_MACOPS, "error programing fw; ret=%d", ret); > return ret; > } Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
