On Thu, Sep 02, 2010 at 11:21:28AM +0200, Johannes Berg wrote: > On Thu, 2010-09-02 at 10:47 +0200, Stanislaw Gruszka wrote: > > > > But they all take the mutex, so they can't run in parallel anyway. So it > > > only becomes an ordering issue, no? > > > > Mutex is not taken all the time in iwl_bg_restart. > > Oh, true, but still. In a restart, why do we need to worry about having > aborted scan_completed? We abort the scan at that point, so if later > scan_completed actually runs we don't really care all that much, since > it won't do anything, no? In patch in current form this is needed to avoid warnings in iwl_wait_for_scan_end() and iwl_cancel_scan_deferred_work(). But I think you have right, patch can be rewritten to not have parallel scan works requirement. Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html