On 08/28/2010 12:54 AM, Thadeu Lima de Souza Cascardo wrote: > The code for rtl8187 does not do per packet TX AGC. Resetting the per > packet TX AGC for rtl8187b appears to increase its overall TX power. > This allows the device to associate and a connection be established > using APs a little further away. > > Tested-by: Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxxxxxx> > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxxxxxx> > Cc: linux-wireless@xxxxxxxxxxxxxxx > Cc: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > Cc: Rogerio Luz Coelho <rogluz.news@xxxxxxxxx> > Cc: Herton Ronaldo Krzesinski <herton@xxxxxxxxxxxxxxx> > Cc: Hin-Tak Leung <hintak.leung@xxxxxxxxx> > --- I'm a little confused here. The subject says not to set the per packet TX AGC, while the submission text says that setting it helps. I don't have access to any documents that describe this register, but I expect that clearing RTL818X_TX_AGC_CTL_PERPACKET_GAIN_SHIFT would disable that feature. As a result the code change seems to match the subject. I have not yet tested this code, but I do note that all the Realtek drivers for the RTL8187B set this bit. Until testing, I withhold judgment on the actual code change, but NACK for the inconsistency. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
