Search Linux Wireless

Re: issues with scanning in mac80211

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 26, 2010 at 4:11 PM, Luis R. Rodriguez
<lrodriguez@xxxxxxxxxxx> wrote:
> As suggested by Jouni, I'll test using min(listen_interval,
> DTIM_PERIOD), this should only help with broadcast / multicast data
> upon a scan. If there are any other thresholds required by userspace
> this should likely be configured on the bg scan module I think.

Ah bleh, we cannot rely on the dtim as it is not exposed to drivers
unless otherwise requested. This can be done by using the new
IEEE80211_HW_NEED_DTIM_PERIOD but this is completely unused by drivers
today.

mcgrof@tux ~/wireless-testing (git::master)$ git grep
IEEE80211_HW_NEED_DTIM_PERIOD drivers/net/wireless/
mcgrof@tux ~/wireless-testing (git::master)$


commit e5b900d228b76d445a4240d9aeb3cd8f79205a91
Author: Johannes Berg <johannes.berg@xxxxxxxxx>
Date:   Thu Jul 29 16:08:55 2010 +0200

    mac80211: allow drivers to request DTIM period

    Some features require knowing the DTIM period
    before associating. This implements the ability
    to wait for a beacon in mac80211 before assoc
    to provide this value. It is optional since
    most likely not all drivers will need this.

    Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
    Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>

.... < amongst other hunks > ...

diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index cf8d721..b6c163a 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -870,6 +870,11 @@ static void ieee80211_set_associated(struct
ieee80211_sub_if_data *sdata,

        ieee80211_led_assoc(local, 1);

+       if (local->hw.flags & IEEE80211_HW_NEED_DTIM_PERIOD)
+               bss_conf->dtim_period = bss->dtim_period;
+       else
+               bss_conf->dtim_period = 0;
+
        bss_conf->assoc = 1;
        /*
         * For now just always ask the driver to update the basic rateset
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux