On Sat, 2010-08-07 at 19:20 +0200, Hauke Mehrtens wrote: > Am 07.08.2010 17:50, schrieb Johannes Berg: > > On Sat, 2010-08-07 at 15:32 +0200, Hauke Mehrtens wrote: > >> This struct was introduced in kernel 2.6.36 and not 2.6.35. > > > > I'm confused now: > > > > $ git describe 7db6f5fb > > v2.6.35-rc1-928-g7db6f5f > > > > johannes > > > Hi, > > I am also confused. ;-) I get the same result for git describe 7db6f5fb > as you. > > But include/linux/kernel.h does not contain struct va_format in kernel > 2.6.35 it was added sometime later. > > Without adding struct va_format to compat-2.6.36.h I get build error > with kernel 2.6.35. Ok ... Hmm. I guess this patch got in multiple times or something, since I can see it in wireless-testing that's based on .35 as well, which was the reason we moved this to compat-2.6.35 because otherwise it failed compilation there! I'm starting to think that we should detect at compile time what features are present, say by test-compiling a file that contains a use of the struct. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html