On Tue, 2010-08-03 at 05:43 -0700, Alex Romosan wrote: > Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > > > Yes, thank you, but it's very strange. But it's probably ok, let's > > remove the call then, it wasn't there before. Want to post a patch > > yourself? > > btw, the old code had this comment > > /* We avoid iwl_commit_rxon here to commit the new filter flags > * since mac80211 will call ieee80211_hw_config immediately. > * (mc_list is not supported at this time). Otherwise, we need to > * queue a background iwl_commit_rxon work. > */ Yes, but that predates this callback being able to sleep, which according to the comment is the reason for not committing here. Now that the callback could sleep, I figured we could safely commit there, I have no idea why that caused issues with your AP. I realised though that mac80211 will sometimes call the filter config w/o calling hw_config() immediately, so I'd prefer actually figuring out what the issue with your AP is. Could you rebuild your kernel with CONFIG_MAC80211_DRIVER_API_TRACER and CONFIG_IWLWIFI_DEVICE_TRACING, get trace-cmd from git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git and record traces for me? I'd like to have trace-cmd record -e iwlwifi -e mac80211 for both the working and non-working case, preferably the same kernel with that single line of code changed. Please compress the output. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
