On Mon, 2010-08-02 at 15:16 +0200, Christian Lamparter wrote: > @@ -110,6 +110,7 @@ struct tid_ampdu_tx { > * @timeout: reset timer value (in TUs). > * @dialog_token: dialog token for aggregation session > * @rcu_head: RCU head used for freeing this struct > + * @lock: controls exclusive access to the struct > * > * This structure is protected by RCU and the per-station > * spinlock. Assignments to the array holding it must hold I think that's misleading. You're only using it to control access to the reorder stuff here, not any of the other things that are used in agg-rx.c. Also, documentation for reorder_timer is missing. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html