On Wednesday 28 July 2010 21:15:53 John W. Linville wrote: > On Wed, Jul 28, 2010 at 09:10:31PM +0200, Christian Lamparter wrote: > > On Wednesday 28 July 2010 20:48:44 John W. Linville wrote: > > > Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx> > > > --- > > > drivers/net/wireless/ath/ar9170/main.c | 17 +++++++++++++++++ > > > 1 files changed, 17 insertions(+), 0 deletions(-) > > > [...] > > One problem: the noisefloor stays at the same level and > > is not updated. You would have to call ar9170_set_channel, > > but I don't recommend that because that may lockup > > the device :(. > > I'm not sure I understand -- isn't ar9170_set_channel already called > from ar9170_op_config? Or are you saying that the value will be > stale unless you call ar9170_set_channel again? the latter... come to think of it, I wrote a RFT a while back: "[RFT] ar9170: implement get_survey" <- 27. April and Benoit joined in to point out that he has/had the same issue with ath9k hardware. Was this ever sorted out? > How is this patch any worse than the situation was before commit > 5d6566ff356a19fb6ad994717cb937ff88063fa6? Well, a dodgy value is hardly an improvement, right? Sure it is _just_ the noise *floor* and people might argue that any value is better than nothing at all. Therefore, yes: Acked-by: Christian Lamparter <chunkeey@xxxxxxxxxxxxxx> and add the nf-update to the TODO-list... Or wait and look how ath9k(_htc) does/did it. Regards, Christian -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
