On Mon, 2010-07-26 at 07:20 -0700, Jouni Malinen wrote: > Well, the latter one may indeed do that since debugfs_remove_recursive() > survives NULL pointer. However, the former one does not. > ieee80211_key_disable_hw_accel() has a key->local dereference and it > oopses without the "if (key->local)" part here (before checking whether > the key is uploaded to hardware). I started first making that handle > unlinked keys, but since this gets called before > ieee80211_key_enable_hw_accel() in the problem case, it looked more > logical to fix the caller not to get to the disable function in the > first place. Oh, indeed, that comes before the check. I agree then, this patch seems like the best fix. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
