On Sat, Jul 24, 2010 at 11:06:25AM +0200, Johannes Berg wrote: > I removed the comment because the linked vs. not linked handling is a > bit different now I think ... I don't think we should restore the NULL > handling as it was before, since __ieee80211_key_free() should be able > to handle this now. > > The fix should be passing in the local pointer to ieee80211_key_free() I > guess. Can you try that? __ieee80211_key_free() handles this, but the function it calls does not.. ieee80211_key_disable_hw_accel() dereferences key->local before checking whether the key has been uploaded to hardware (which this key would not be).. Would you like the local pointer to be passed to ieee80211_key_disable_hw_accel(), too? Or make __ieee80211_key_destroy() skip that call if key->local == NULL? Actually, calling __ieee80211_key_destroy() with not-yet-linked key is somewhat odd from the debugfs view point, too (ieee80211_debugfs_key_remove() gets called even when matching _key_add has not happened). -- Jouni Malinen PGP id EFC895FA -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
