On Thu, Jul 22, 2010 at 09:45:10AM +0200, Kalle Valo wrote: > On 07/22/2010 08:34 AM, Luciano Coelho wrote: > >> @@ -467,7 +467,7 @@ static int wl1251_boot_upload_nvs(struct wl1251 *wl) > >> val = (nvs_ptr[0] | (nvs_ptr[1] << 8) > >> | (nvs_ptr[2] << 16) | (nvs_ptr[3] << 24)); > >> > >> - val = cpu_to_le32(val); > >> + val = (u32 __force) cpu_to_le32(val); > > > > This will work, but such casts always make me a bit suspicious. I think > > this is fine for now > > This line was very suspicious already from beginning, I can't remember > why it was added and I don't see why it's needed here. It certainly is a bit strange, and rather ugly as well. I agree that the write should probably just take the le32 instead, but I was more interested in silencing sparse than in rewriting a driver for which I have not hardware. :-) I could drop that hunk for the time being? John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
