On Tue, Jul 20, 2010 at 08:22:03PM +0200, Johannes Berg wrote: > On Tue, 2010-07-20 at 14:07 -0400, John W. Linville wrote: > > > off = le32_to_cpu(cmd->rxwrptr) & 0xffff; > > - iowrite32(cpu_to_le32(priv->rxq[0].rxd_dma), priv->sram + off); > > + iowrite32((__force __u32) cpu_to_le32(priv->rxq[0].rxd_dma), > > + priv->sram + off); > > Those don't seem right, it looks more like somebody thought they needed > to byteswap the iowrite because PCI(e) is little endian, and were wrong? Yeah, I agree. I was going with the thought that "it's working, so I guess it is right". But then, development was probably done on an LE system... John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
