On Tue, Jun 22, 2010 at 9:31 AM, Matthew Garrett <mjg@xxxxxxxxxx> wrote: > On Mon, Jun 21, 2010 at 01:39:07PM -0700, Luis R. Rodriguez wrote: >> Last I reviewed CONFIG_PCIEASPM won't buy you *anything* other than >> debugging knobs. With it you can force all devices to enable ASPM >> completely on or disable it. Both of which I think are not really >> useful and instead should be done in userspace given that if you are >> testing ASPM you likely want to test only one one device and its >> respective root complex, not all at the same time. > > It buys you enabling of ASPM on devices that the BIOS hasn't configured, > which is legitimate and useful. Sure, I agree with that, but it also will enable ASPM for *all* devices which have the capability which IMHO is a terrible idea for users when all they want to do is enable ASPM for one device. Instead I recommend users to enable ASPM for their devices selectively and from userspace. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
