Search Linux Wireless

Re: IWL3945 problems in 2.6.35-rc1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Maxim,

Thanks for the quick reply!

> >  1) with the patch reverted, which is what presumably you're running
> >     now, can you try
> >     ifconfig wlan0 allmulti
> >     ifconfig wlan0 -allmulti
> > 
> >     I think this will *break* the driver right now.
> 
> I didn't exactly understand how this supposed to break it.

Ok this needs some more explaining.

The old code did:

if (allmulti changed)
	"set grp-filter in hw according to allmulti"

the new code just did

"set grp-filter in hw according to allmulti"


During normal operation the "allmulti changed" condition is never true.
Therefore, the old code, despite being incorrect, never broke things.
The above would make the condition true, and lead to it being broken
because it would change to on/off and then the grp-filter in hw would be
off, although it's required to be on.

Thus the real bug was there before my change, but it never triggered,
and when I "optimised away" the condition I broke it.

> >  2) with the patch *not* reverted, apply the patch below and see if that
> >     fixes the problem as well (if it gets mangled, just remove the one
> >     CHK() line manually)
> > 
> > Actually, (2) is obviously more important to me, but (1) would indicate
> > that my guess is correct wrt. what's causing the problem

> I tested (2) and it works.

Thank you. I'll submit this patch instead.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux