On Tue, Jun 15, 2010 at 7:41 PM, Leann Ogasawara <leann.ogasawara@xxxxxxxxxxxxx> wrote: > On Tue, 2010-06-15 at 18:20 -0700, Luis R. Rodriguez wrote: >> On Tue, Jun 15, 2010 at 5:55 PM, Leann Ogasawara >> <leann.ogasawara@xxxxxxxxxxxxx> wrote: >> > Hi All, >> > >> > As documented in 2005 in Documentation/networking/README.ipw2200, "The >> > LED code has been reported to hang some systems when running ifconfig >> > and is therefore disabled by default." We've however been carrying the >> > following patch in our Ubuntu kernel for quite some time which enables >> > the ipw2200 LED by default. This was a result of numerous user >> > requests. We've seen no subsequent bug reports of systems hanging due >> > to the the LED code being enabled by default. I'd therefore like to >> > propose the following patch to enable the LED by default. This patch >> > was originally authored by TJ. I apologize in advance that I do not >> > have TJ's full first and last name for provenance. >> > >> > Thanks, >> > Leann >> > >> > >From 315246037a0edab4d626de6ccb68c73d3fe61ce3 Mon Sep 17 00:00:00 2001 >> > From: ubuntu@xxxxxxxxxxx <ubuntu@xxxxxxxxxxx> >> > Date: Mon, 23 Mar 2009 20:29:28 +0000 >> > Subject: [PATCH] ipw2200: Enable LED by default >> > >> > BugLink: http://bugs.launchpad.net/bugs/21367 >> > >> > Enable LED by default and update the MODULE_PARM_DESC. The original >> > reason for defaulting to disabled was documented in 2005 and noted, "The >> > LED code has been reported to hang some systems when running ifconfig >> > and is therefore disabled by default." This no longer appears >> > applicable and users have been requesting this be enabled for several >> > years. >> > >> > Originally-by: TJ <ubuntu@xxxxxxxxxxx> >> >> Does Originally-by also imply he has read the Certificate of Origin >> and that he agrees for his code to be used in that way? That is the >> purpose of the SOB anyway, but if you took his code, does that imply >> that he agrees to it too? > > I'd CC'd TJ on the initial email, so I'm hoping he will respond here to > your inquiry. I can say that he had submitted the original form of the > patch to the Ubuntu kernel-team mailing list back in March, 2009: > > https://lists.ubuntu.com/archives/kernel-team/2009-March/005013.html > > In that original submission he did provide his official SOB. > > The patch was then applied with slight modification by Tim Gardner to > the Ubuntu kernel. In forwarding this upstream, I wanted to give TJ the > proper credit for originating the patch even though it's undergone some > slight modification (ie the MODULE_PARM_DESC change). TJ had not > officially signed off on this final form of the patch which is the > reason I used "Originally-by:". If there is a better approach please > let me know. In that case I would just recommend to keep his original SOB, then it would go through you/tim whoever it goes through until it reaches Linus. But just my $0.02. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
