On Tue, Jun 15, 2010 at 10:59:05AM -0700, Leann Ogasawara wrote: > On Mon, 2010-06-14 at 14:55 -0400, John W. Linville wrote: > > So, I guess you are concerned about the groupings because of the > > different firmwares or something like that? Perhaps a comment that > > says "this could be a version 2 device" is just as handy? Since the > > driver prints the name of the firmware it wants, is there any real > > need for grouping the IDs? > > > > OTOH, is there any actual harm from the duplicate entry? It "seems" > > wrong to me too, but I guess it does no harm...? > > I don't believe there is any harm from the duplicate entry, it just > seemed unnecessary. > > > Leann and/or Ben, was this just tidying-up? I'm guessing there wasn't > > an actual bug involved? > > Indeed, this was just a patch we'd been carrying to tidy things up. > There was no actual bug involved. I'd be happy to send a v2 of the > patch which comments out the duplicate entry and adds a note as to why. > Or I'd be fine just leaving the code as is and we'll drop the patch > we're carrying locally in Ubuntu. FWIW, I like the 'comment-out and add a note' option. Thanks! John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
