On Thu, 2010-06-10 at 09:44 +0530, Sujith wrote:
> Johannes Berg wrote:
> > switch (mgmt->u.action.u.addba_req.action_code) {
> > case WLAN_ACTION_ADDBA_REQ:
> > if (len < (IEEE80211_MIN_ACTION_SIZE +
> > sizeof(mgmt->u.action.u.addba_req)))
> > - return RX_DROP_MONITOR;
> > - ieee80211_process_addba_request(local, rx->sta, mgmt, len);
> > - goto handled;
> > + goto invalid;
> > + break;
> > case WLAN_ACTION_ADDBA_RESP:
> > if (len < (IEEE80211_MIN_ACTION_SIZE +
> > sizeof(mgmt->u.action.u.addba_resp)))
> > - break;
> > - ieee80211_process_addba_resp(local, rx->sta, mgmt, len);
> > - goto handled;
> > + goto invalid;
> > + break;
> > case WLAN_ACTION_DELBA:
> > if (len < (IEEE80211_MIN_ACTION_SIZE +
> > sizeof(mgmt->u.action.u.delba)))
> > - break;
> > - ieee80211_process_delba(sdata, rx->sta, mgmt, len);
> > - goto handled;
> > + goto invalid;
> > + break;
> > + default:
> > + goto invalid;
> > }
>
> rx->sta->rx_packets is no longer incremented for valid action frames,
> since we return immediately after queuing to sdata.
Good catch, I guess I broke that earlier and also with other frames that
are put onto the skb queue. I don't think I want to go back and fix it
so I'll go add a patch to the series that takes care of this for all the
possible cases.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
