From: ext Johannes Berg [johannes@xxxxxxxxxxxxxxxx] > >On Tue, 2010-06-08 at 16:05 +0300, Juuso Oikarinen wrote: > >> + promisc = sdata->flags & IEEE80211_SDATA_PROMISC; >> + if (promisc) >> + bss_conf->arp_filter_enabled = 0; >> + else >> + bss_conf->arp_filter_enabled = sdata->arp_filter_state; > >bss_conf->arp_filter_enabled = !promisc && sdata->arp_filter_state; > >? > >Or if not, use false instead of 0 please. > Yes, sure I can change this. My home WLAN is giving me a headache, so I can't seem to access my work machine just now, but I began to wonder if I managed to create the same locking problem in this patch I had before. To traverse the interface list we need to acquire a lock - either the mutex for the iflist (which seems not to be an option as we also need the mgd mutex - to be locked after the iflist mutex) or the rtnl lock, which I chose to acquire. I quess the filter reconfig work is in the same mac80211 workqueue as the rest of the stuff, so the rtnl lock problem is there again. -Juuso >johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
