On Monday 07 June 2010 18:03:28 you wrote: > On Mon, 2010-06-07 at 15:58 +0900, Bruno Randolf wrote: > > +static int nl80211_get_antenna(struct sk_buff *skb, struct genl_info > > *info) +{ > > + struct cfg80211_registered_device *rdev; > > + struct sk_buff *msg; > > + void *hdr; > > + int res; > > + u8 tx_ant, rx_ant; > > You should probably set them both to 0 here, ok. > > + res = rdev->ops->get_antenna(&rdev->wiphy, &tx_ant, &rx_ant); > > + if (res) > > + goto free_msg; > > and complain about the driver if they still are after this. would that be a WARN_ON? thanks, bruno -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html