On Fri, Jun 04, 2010 at 06:32:18PM +0200, Nils Radtke wrote: > Hi John, > > http://marc.info/?l=linux-wireless&m=127317062320707&w=2 : > > > > The BUG_ON was introduced by: > > > > commit 3110bef78cb4282c58245bc8fd6d95d9ccb19749 > > > > Author: Guy Cohen <guy.cohen@xxxxxxxxx> > > > > Date: Tue Sep 9 10:54:54 2008 +0800 > > > > > > > > iwlwifi: Added support for 3 antennas > > > > > > > > ... the portion adding the BUG_ON is reverted since we are encountering the error > > > > and BUG_ON was created with assumption that error is not encountered. > > > > > > > > Signed-off-by: Reinette Chatre <reinette.chatre@xxxxxxxxx> > > > > --- > > > > > > I noticed this patch in your wireless-next-2.6 pull request. Since it is > > > addressing a system hang issue, could it perhaps be included in > > > wireless-2.6 also? I should have included the bug report reference for > > > this purpose, sorry ... it is > > > https://bugzilla.redhat.com/show_bug.cgi?id=588021 > > > > I didn't send it that way because a) that code has been there for a > > really long time; and b) the reporter couldn't reliably reproduce > > the bug and therefore can't reliably test the fix. While I agree > > that the fix looks harmless, no update is zero-risk. > > > > Can you reliably hit that code? Has it been tested enough that we > > should risk holding-up 2.6.34's release for it? > I'm one of those _very reliably_ hitting this BUG. I can tell how > annoying it is. I have to backport the patch w/ every kernel release > to be able to use the wireless link _at all_. So please consider > it as somewhat urgent to get the patch included. > > I'm still in contact w/ Reinette regularly to get those problems fixed. > It involves physically moving around the city for testing any modification > so this working is slowly processing as it takes every time an enormous > amount of time to do so. Work in (slow) progress, but it's alive.. > C.f. http://permalink.gmane.org/gmane.linux.kernel/992941 > > BTW, https://bugzilla.redhat.com/show_bug.cgi?id=588021 this isn't fixed. > Maybe RH did fix it. kernel.org sources haven't. This is a blocker ever > since. The patch is in linux-2.6. I suppose it could go to stable@xxxxxxxxxxx commit 3d79b2a9eeaa066b35c49fbb17e3156a3c482c3e Author: Reinette Chatre <reinette.chatre@xxxxxxxxx> Date: Mon May 3 10:55:07 2010 -0700 iwlwifi: recalculate average tpt if not current We currently have this check as a BUG_ON, which is being hit by people. Previously it was an error with a recalculation if not current, return that code. The BUG_ON was introduced by: commit 3110bef78cb4282c58245bc8fd6d95d9ccb19749 Author: Guy Cohen <guy.cohen@xxxxxxxxx> Date: Tue Sep 9 10:54:54 2008 +0800 iwlwifi: Added support for 3 antennas ... the portion adding the BUG_ON is reverted since we are encountering the and BUG_ON was created with assumption that error is not encountered. Signed-off-by: Reinette Chatre <reinette.chatre@xxxxxxxxx> Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx> -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
