On Wed, May 26, 2010 at 7:06 PM, Vasanthakumar Thiagarajan
<vasanth@xxxxxxxxxxx> wrote:
> This bug was introduced by the following commit
>
> Author: Vasanthakumar Thiagarajan <vasanth@xxxxxxxxxxx>
> Date: Thu Apr 15 17:38:46 2010 -0400
>
> ath9k: Remove ATH9K_TX_SW_ABORTED and introduce a bool for this purpose
>
> Wrong buffer is checked for bf_tx_aborted field in ath_tx_num_badfrms(),
> this may result in a rate scaling with wrong feedback (number
> of unacked frames in this case). It is the last one in the chain
> of buffers for an aggregate frame that should be checked.
>
> Also it misses the initialization of this field in the buffer,
> this may lead to a situation where we stop the sw retransmission
> of failed subframes associated to this buffer.
>
> Signed-off-by: Vasanthakumar Thiagarajan <vasanth@xxxxxxxxxxx>
> ---
FWIW, for those who want to test this, I've applied this patch into
the compat-wireless linux-next-pending/ directory. I've also kicked
out a new linux-next based compat-wireless tarball with the
pending+crap patches applied and fixed today's new compile issue
introduced by:
Author: Alexey Dobriyan <adobriyan@xxxxxxxxx>
Date: Mon May 24 14:33:03 2010 -0700
kernel-wide: replace USHORT_MAX, SHORT_MAX and SHORT_MIN with
USHRT_MAX, SHRT_MAX and SHRT_MIN
- C99 knows about USHRT_MAX/SHRT_MAX/SHRT_MIN, not
USHORT_MAX/SHORT_MAX/SHORT_MIN.
- Make SHRT_MIN of type s16, not int, for consistency.
[akpm@xxxxxxxxxxxxxxxxxxxx: fix drivers/dma/timb_dma.c]
[akpm@xxxxxxxxxxxxxxxxxxxx: fix security/keys/keyring.c]
Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
Acked-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
This fix required a simple patch on compat.git.
The "pc" compat-wireless tarball for today then is:
http://www.orbit-lab.org/kernel/compat-wireless-2.6/compat-wireless-2010-05-26-pc.tar.bz2
sha1sum: 62937a3bec62cc564731b30295b44994504355cf
I've compile and load tested ath9k against 2.6.31-20-generic
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
