Search Linux Wireless

Re: [PATCH] ath9k: Fix ath_print in xmit for harware reset.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 26, 2010 at 11:01 AM, Justin P. Mattock
<justinmattock@xxxxxxxxx> wrote:
> On 05/26/2010 10:50 AM, Luis R. Rodriguez wrote:
>>
>> On Wed, May 26, 2010 at 10:46 AM, Justin P. Mattock
>> <justinmattock@xxxxxxxxx>  wrote:
>>
>>>
>>> ath_print in xmit.c should say "Reseting hardware"
>>> instead of Resetting HAL!(since HAL is being fazed out).
>>> dmesg shows:
>>> [ 8660.899624] ath: Failed to stop TX DMA in 100 msec after killing last
>>> frame
>>> [ 8660.899676] ath: Unable to stop TxDMA. Reset HAL!
>>>
>>>  Signed-off-by: Justin P. Mattock<justinmattock@xxxxxxxxx>
>>>
>>> ---
>>>  drivers/net/wireless/ath/ath9k/xmit.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/net/wireless/ath/ath9k/xmit.c
>>> b/drivers/net/wireless/ath/ath9k/xmit.c
>>> index 3db1917..617db8e 100644
>>> --- a/drivers/net/wireless/ath/ath9k/xmit.c
>>> +++ b/drivers/net/wireless/ath/ath9k/xmit.c
>>> @@ -1198,7 +1198,7 @@ void ath_drain_all_txq(struct ath_softc *sc, bool
>>> retry_tx)
>>>                int r;
>>>
>>>                ath_print(common, ATH_DBG_FATAL,
>>> -                         "Unable to stop TxDMA. Reset HAL!\n");
>>> +                         "ath9k: Failed to stop TX DMA. Resetting
>>> hardware!\n");
>>>
>>
>> Nack, No need to put "ath9k:" since ath_print already prepends "ath: "
>>
>>   Luis
>>
>>
>
> ah.. so the ATH_DBG_FATAL takes care of that?
> resent..

No FATAL just makes sure it prints all the time, even if you do not
have debugging enabled. Go read ath_print() though.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux