Search Linux Wireless

Re: [PATCH]wireless:ath9k Disable leds for Apple products.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/26/2010 10:18 AM, John W. Linville wrote:
On Wed, May 26, 2010 at 10:14:16AM -0700, Justin P. Mattock wrote:
Disable the leds on ath9k for Apple products, since
there is no leds on any of there machines(or non that I can find!!).

  Signed-off-by: Justin P. Mattock<justinmattock@xxxxxxxxx>

  void ath_init_leds(struct ath_softc *sc)
  {
  	char *trigger;
  	int ret;

+	/* Apple has no leds lights for their wireless.  */
+	if (dmi_check_system(dmi_system_table)>  0)
+		return -ENODEV;
+	else
+
  	if (AR_SREV_9287(sc->sc_ah))
  		sc->sc_ah->led_pin = ATH_LED_PIN_9287;
  	else
Surely we don't need the 'else'.

Does enabling the LEDs on these systems cause any problems?

John
I picked up the idea, from this patch:
http://kerneltrap.org/mailarchive/linux-kernel/2010/1/20/4530535
while looking into a bug for ath9k(thinking maybe leds
are causing something, which want  the case)

so Id have to say I don't think the leds cause issue's,
if anything just a wasted symlink, call, or whatever
in /sys/class/leds/*

Justin P. mattock

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux