Search Linux Wireless

Re: [RFC PATCHv2] mac80211: Add support for hardware ARP query filtering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2010-05-26 at 13:52 +0200, ext Johannes Berg wrote:
> On Wed, 2010-05-26 at 14:29 +0300, Juuso Oikarinen wrote:
> 
> > --- a/net/mac80211/mlme.c
> > +++ b/net/mac80211/mlme.c
> > @@ -858,6 +858,10 @@ static void ieee80211_set_associated(struct ieee80211_sub_if_data *sdata,
> >  	ieee80211_recalc_smps(local, sdata);
> >  	mutex_unlock(&local->iflist_mtx);
> >  
> > +	rtnl_lock();
> > +	ieee80211_set_arp_filter(sdata);
> > +	rtnl_unlock();
> > +
> 
> Please analyse locking in more detail and enable lockdep :)
> 
> This will cause deadlocks.

I have lockdep permanently enabled in my development kernel. It has
given me no complaints in testing with the corresponding wl1271 driver
patch.

But I will look into those locks further if I can figure out any
deadlock scenarios.

-Juuso


> johannes
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux