On Wed, 2010-05-26 at 14:14 +0300, Juuso Oikarinen wrote:
> > > +static inline int drv_configure_ip_filter(struct ieee80211_hw *hw,
> > > + struct in_ifaddr *ifa_list)
> > > +{
> > > + struct ieee80211_local *local = hw_to_local(hw);
> > > + int ret = 0;
> > > +
> > > + if (local->ops->configure_ip_filter)
> > > + ret = local->ops->configure_ip_filter(hw, ifa_list);
> > > + return ret;
> > > +}
> >
> > Tracing would be nice, you should even able able to trace all addresses
> > in a variable-length array.
> >
>
> I looked into the tracing. I still prefer using the ifa_list directly as
> argument to the driver, and not copy the addresses in it to another
> array.
>
> The ifa_list is a linked list, and does AFAIK does not directly fit into
> the tracing infrasturcture.
>
> Hence I added a trace for this op, but omitted tracing the IP addresses.
Yeah, that's fine ... it later occurred to me that I also left that out
for the multicast list for exactly this reason.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
