Search Linux Wireless

Re: [PATCH 1/3] ath9k: Make sure null func frame is acked before going into PS for ar9003

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 23, 2010 at 12:13:54AM +0530, Kalle Valo wrote:
> Vasanthakumar Thiagarajan <vasanth@xxxxxxxxxxx> writes:
> 
> > Add missing code to handle nullfunc frame completion in
> > ath_tx_edma_tasklet().
> 
> [...]
> 
> > +		/*
> > +		 * Make sure null func frame is acked before configuring
> > +		 * hw into ps mode.
> > +		 */
> > +		if (bf->bf_isnullfunc && txok) {
> > +			if ((sc->ps_flags & PS_ENABLED))
> > +				ath9k_enable_ps(sc);
> > +			else
> > +				sc->ps_flags |= PS_NULLFUNC_COMPLETED;
> > +		}
> 
> Few months ago a similar test was added to mac80211. Why does ath9k
> need this also in the driver?
> 

Right, but this patch is needed unless the logic which checks for
completion of null func in driver is cleaned up. I'll do this clean
up later. thanks.

Vasanth
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux