Search Linux Wireless

Re: [PATCH] ath9k: Fix rx of mcast/bcast frames in PS mode with auto sleep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Vasanthakumar Thiagarajan <vasanth@xxxxxxxxxxx> writes:

> Signed-off-by: Vasanthakumar Thiagarajan <vasanth@xxxxxxxxxxx>

Please describe more, this isn't very informative (if any). Especially
try to answer in the commit log:

o What was the original bug? How and why did it happen?
o How was it visible to the user?
o How does the fix actually fix the issue?
o In what version was the bug introduced? This helps backporters.

Powersave in 802.11 is very fragile and more information there is, the
easier it is to handle the issues.

> +#define ATH9K_CHECK_AUTO_SLEEP(__sc) \
> +	(__sc->ps_enabled && \
> +	(__sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_AUTOSLEEP))

Like Andrew Morton says: use C instead of CPP. Meaning that this can
be an inline function instead of a macro.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux