2010/5/19 Bruno Randolf <br1@xxxxxxxxxxx>: > As far as we know, only NF calibration interferes with RX/TX so we can > leave the queues enabled for the other calibrations. > > BTW: Stopping the queues is not enough for avoiding transmissions, since there > might be packets in the queue + beacons are also sent regularly! But i leave it > like this until we have a better solution (stopping TX DMA?). > > Signed-off-by: Bruno Randolf <br1@xxxxxxxxxxx> > --- > drivers/net/wireless/ath/ath5k/base.c | 11 ++++++----- > 1 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c > index 88c7314..3206ed6 100644 > --- a/drivers/net/wireless/ath/ath5k/base.c > +++ b/drivers/net/wireless/ath/ath5k/base.c > @@ -2785,10 +2785,6 @@ ath5k_tasklet_calibrate(unsigned long data) > /* Only full calibration for now */ > ah->ah_cal_mask |= AR5K_CALIBRATION_FULL; > > - /* Stop queues so that calibration > - * doesn't interfere with tx */ > - ieee80211_stop_queues(sc->hw); > - > ATH5K_DBG(sc, ATH5K_DEBUG_CALIBRATE, "channel %u/%x\n", > ieee80211_frequency_to_channel(sc->curchan->center_freq), > sc->curchan->hw_value); > @@ -2806,8 +2802,13 @@ ath5k_tasklet_calibrate(unsigned long data) > ieee80211_frequency_to_channel( > sc->curchan->center_freq)); > > + /* TODO: We don't need to run noise floor calibration as often > + * as I/Q calibration.*/ > + > + /* Noise floor calibration interrupts rx/tx path while I/Q calibration > + * doesn't. Stop queues so that calibration doesn't interfere with tx */ > + ieee80211_stop_queues(sc->hw); > ath5k_hw_update_noise_floor(ah); > - /* Wake queues */ > ieee80211_wake_queues(sc->hw); > > ah->ah_cal_mask &= ~AR5K_CALIBRATION_FULL; > Acked-by: Nick Kossifidis <mickflemm@xxxxxxxxx> -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
