Search Linux Wireless

[patch -next 1/2] ath9k_htc: dereferencing before check in hif_usb_tx_cb()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dan Carpenter wrote:
> After c11d8f89d3b7: "ath9k_htc: Simplify TX URB management" we no longer
> assume that tx_buf is a non-null pointer.
> 
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>

Thanks.

Acked-by: Sujith <Sujith.Manoharan@xxxxxxxxxxx>

> diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
> index 46dc41a..ac82911 100644
> --- a/drivers/net/wireless/ath/ath9k/hif_usb.c
> +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
> @@ -107,12 +107,14 @@ static inline void ath9k_skb_queue_purge(struct hif_device_usb *hif_dev,
>  static void hif_usb_tx_cb(struct urb *urb)
>  {
>  	struct tx_buf *tx_buf = (struct tx_buf *) urb->context;
> -	struct hif_device_usb *hif_dev = tx_buf->hif_dev;
> +	struct hif_device_usb *hif_dev;
>  	struct sk_buff *skb;
>  
> -	if (!hif_dev || !tx_buf)
> +	if (!tx_buf || !tx_buf->hif_dev)
>  		return;
>  
> +	hif_dev = tx_buf->hif_dev;
> +
>  	switch (urb->status) {
>  	case 0:
>  		break;
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux