On Saturday 15 May 2010 01:04:34 Luis R. Rodriguez wrote: > On Fri, May 14, 2010 at 12:50 AM, Bruno Randolf <br1@xxxxxxxxxxx> wrote: > > We should use the same buffer size we set up for DMA also in the hardware > > descriptor. Previously we used common->rx_bufsize for setting up the DMA > > mapping, but skb_tailroom(skb) for the size we tell to the hardware in > > the descriptor itself. The problem is that skb_tailroom(skb) can give us > > a larger value than the size we set up for DMA before: In my case > > rx_bufsize is 2528, and we allocated an skb of 2559 bytes length, > > including padding for cache alignment, but sbk_tailroom() was 2592. Just > > consistently use rx_bufsize for all RX DMA memory sizes. > > > > Also check the return value of setup function. > > > > Signed-off-by: Bruno Randolf <br1@xxxxxxxxxxx> > > Cc: stable? might be useful. i just would like some review before that. > Is that other bug reproducible, can the user test this to cure it? not sure. seems like he can with running kismet for a few hours (i'm doing the same over the weekend). i doubt that this is "the" bug though... a) because the bug on ath5k and ath9k are so similar and b) because we see the beginning of packets. rather looks like the next pointer of the descriptor is pointing to somewhere it shouldnt, sometimes? (guessing) bruno -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
