Hi Sascha, > -----Original Message----- > From: libertas-dev-bounces@xxxxxxxxxxxxxxxxxxx [mailto:libertas-dev- > bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Sascha Silbe > > On Wed, May 12, 2010 at 10:07:55PM -0700, Kiran Divekar wrote: > [if_usb_suspend()] > > + if (priv->wol_criteria == 0xffffffff) { > Again, s/0xffffffff/EHS_REMOVE_WAKEUP/. > > > + lbs_pr_info("Suspend attempt without " > > + "configuring wake params!\n"); > > + return -ENOSYS; > > + } > AFAICT this would cause a USB-connected libertas chip with WOL > disabled ("ethtool eth0 d") to prevent suspend, instead of just > powering down like an SDIO-connected chip. So instead of failing > during > lbs_host_sleep_cfg() because the 8388 doesn't support > EHS_REMOVE_WAKEUP, you just bail out earlier, still breaking suspend. > Earlier also this check was there in lbs_suspend() (in main.c). I just moved it to if_usb_suspend (in if_usb.c). In both the cases It's going to bail out earlier. So I don't see any side affects on USB suspend due to this patch. Your other comments looks fine to me. I will modify the patch accordingly. > > > diff --git a/drivers/net/wireless/libertas/main.c > > b/drivers/net/wireless/libertas/main.c Thanks, Amit -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
