On Tue, May 11, 2010 at 1:39 AM, Bruno Randolf <br1@xxxxxxxxxxx> wrote: Subject should be for cfg80211, not mac80211. In fact can you submit the mac80211 stuff in a separate secondary patch? Some more comments below. > Allow setting TX and RX antenna configuration via nl80211/cfg80211. I think we should call this TX / RX chainmask given that with 802.11n hardware this is what this is called. > The antenna configuration is defined as a bitmap of allowed antennas. This > bitmap is 8 bit at the moment, each bit representing one antenna. If you use chainmask for this instead of 'antenna configuration' the wording would be something like: The chainmask is defined as a bitmap of chain configurations used for TX/RX. The bitmap allows for configuring up to up to 4 chains for both TX and RX, 4 bits for each TX chain, 4 bits for each RX chain. > If multiple > antennas are selected, the driver may use diversity for receive and transmit. For 802.11n this is called "selection diversity" but typically just referred to as "diversity", for legacy this is called "antenna diversity". It may be good to elaborate how selection diversity or antenna diversity might be enabled, ie, will this be another command, or what. I think for legacy another command makes sense, and it may be possible for us to use the same command for enabling selection diversity, I am not sure if we can fine tune the diversity algorithm at this time, I will have to review this and get back to you. > This allows for a simple, yet flexible configuration interface for antennas, > while drivers may reject configurations they cannot support. :) ! Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
