On Sat, 2010-05-08 at 18:25 +0200, ext Dan Carpenter wrote: > The "(wl == NULL)" test doesn't work here because "wl" is always > non-null. The intent of the code is to return if the interface > was not supported by the driver. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > diff --git a/drivers/net/wireless/wl12xx/wl1271_main.c b/drivers/net/wireless/wl12xx/wl1271_main.c > index b61cd10..55aa813 100644 > --- a/drivers/net/wireless/wl12xx/wl1271_main.c > +++ b/drivers/net/wireless/wl12xx/wl1271_main.c > @@ -852,7 +852,7 @@ static int wl1271_dev_notify(struct notifier_block *me, unsigned long what, > if (wl == wl_temp) > break; > } > - if (wl == NULL) > + if (wl != wl_temp) > return NOTIFY_DONE; > > /* Get the interface IP address for the device. "ifa" will become Thanks for the fix. Acked-by: Luciano Coelho <luciano.coelho@xxxxxxxxx> -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
