Search Linux Wireless

[patch 5/9] ath9k/htc_drv_main: off by one error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dan Carpenter wrote:
> I changed "> ATH9K_HTC_MAX_TID" to ">= ATH9K_HTC_MAX_TID" to avoid a
> potential overflow.
> 
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>

Thanks.

Acked-by: Sujith <Sujith.Manoharan@xxxxxxxxxxx>

> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> index e75db06..6c386da 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> @@ -465,7 +465,7 @@ static int ath9k_htc_aggr_oper(struct ath9k_htc_priv *priv,
>  	int ret = 0;
>  	u8 cmd_rsp;
>  
> -	if (tid > ATH9K_HTC_MAX_TID)
> +	if (tid >= ATH9K_HTC_MAX_TID)
>  		return -EINVAL;
>  
>  	memset(&aggr, 0, sizeof(struct ath9k_htc_target_aggr));
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux