On Thu, May 06, 2010 at 09:11:08AM -0700, reinette chatre wrote: > On Mon, 2010-05-03 at 10:55 -0700, reinette chatre wrote: > > From: Reinette Chatre <reinette.chatre@xxxxxxxxx> > > > > We currently have this check as a BUG_ON, which is being hit by people. > > Previously it was an error with a recalculation if not current, return that > > code. > > > > The BUG_ON was introduced by: > > commit 3110bef78cb4282c58245bc8fd6d95d9ccb19749 > > Author: Guy Cohen <guy.cohen@xxxxxxxxx> > > Date: Tue Sep 9 10:54:54 2008 +0800 > > > > iwlwifi: Added support for 3 antennas > > > > ... the portion adding the BUG_ON is reverted since we are encountering the error > > and BUG_ON was created with assumption that error is not encountered. > > > > Signed-off-by: Reinette Chatre <reinette.chatre@xxxxxxxxx> > > --- > > I noticed this patch in your wireless-next-2.6 pull request. Since it is > addressing a system hang issue, could it perhaps be included in > wireless-2.6 also? I should have included the bug report reference for > this purpose, sorry ... it is > https://bugzilla.redhat.com/show_bug.cgi?id=588021 I didn't send it that way because a) that code has been there for a really long time; and b) the reporter couldn't reliably reproduce the bug and therefore can't reliably test the fix. While I agree that the fix looks harmless, no update is zero-risk. Can you reliably hit that code? Has it been tested enough that we should risk holding-up 2.6.34's release for it? John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
