On Mon, 2010-05-03 at 15:16 -0700, Luis R. Rodriguez wrote: > > Note: 11n shouldn't be done there, in case somebody > > got ideas!! > > Well you mean 802.11n standard stuff, I take it, because there are > vendor 802.11n specific stuff. Well most of it should really be standardised :) > > + * @vendor_radiotap_bitmap: radiotap vendor namespace presence bitmap > > + * @vendor_radiotap_len: radiotap vendor namespace length > > + * @vendor_radiotap_align: radiotap vendor namespace alignment. Note > > + * that the actual data must be at the start of the SKB data > > + * already. > > I see your WARN_ON() on the alignment being set to 0 and set it to 1 > then. Can you clarify a little more on this here. If there is no > strict alignment requirements why not just treat 0 as 1 then? Just want people to be aware that they need to think about alignment -- zero being the default value for most things here due to kzalloc would mean accepting it people wouldn't think about allocations. And most of the time alignment should be required. > > @@ -190,11 +218,26 @@ ieee80211_add_rx_radiotap_header(struct > > /* IEEE80211_RADIOTAP_RX_FLAGS */ > > /* ensure 2 byte alignment for the 2 byte field as required */ > > if ((pos - (u8 *)rthdr) & 1) > > - pos++; > > + *pos++ = 0; > > Why is this needed though? We already memset(rthdr, 0, rtap_len); above. Yeah you're probably right, dunno. > > + vendor_data = skb_push(skb, 4); > > + rx_status.vendor_radiotap_len = 4; > > + rx_status.vendor_radiotap_align = 4; > > + rx_status.vendor_radiotap_oui[0] = 0xff; > > + rx_status.vendor_radiotap_oui[1] = 0xff; > > + rx_status.vendor_radiotap_oui[2] = 0xff; > > + rx_status.vendor_radiotap_subns = 129; > > + rx_status.vendor_radiotap_bitmap = 0x1; > > + > > + *vendor_data++ = 1; > > + *vendor_data++ = 2; > > + *vendor_data++ = 3; > > + *vendor_data++ = 4; > > + > > Heh nice, now we just need a sample radiotap vendor extension parser example. http://git.sipsolutions.net/?p=radiotap.git;a=summary https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4421 johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
